-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border-radius changes to v3 migration guide #1261
Conversation
Hey @robinmetral, Thanks! |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/2sbVa8b8HjzPPDLmRM4AL9GSNLoX |
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
=======================================
Coverage 92.03% 92.03%
=======================================
Files 184 184
Lines 3630 3630
Branches 1170 1170
=======================================
Hits 3341 3341
Misses 271 271
Partials 18 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose
We were missing information about the border-radius scale changes in the migration guide for v3 (implementation PR: #980)
Approach and changes
Add an entry to the migration guide with the changes and a reference to the codemod:
Definition of done
Unit and integration testsMeets minimum browser supportMeets accessibility requirements