Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border-radius changes to v3 migration guide #1261

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Nov 9, 2021

Purpose

We were missing information about the border-radius scale changes in the migration guide for v3 (implementation PR: #980)

Approach and changes

Add an entry to the migration guide with the changes and a reference to the codemod:

Screenshot 2021-11-09 at 11 08 09

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@sumup-clark
Copy link

sumup-clark bot commented Nov 9, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021

⚠️ No Changeset found

Latest commit: e523305

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/2sbVa8b8HjzPPDLmRM4AL9GSNLoX
✅ Preview: https://oss-circuit-ui-git-update-migration-guide-sumup.vercel.app

@robinmetral robinmetral marked this pull request as ready for review November 9, 2021 10:09
@robinmetral robinmetral requested a review from a team as a code owner November 9, 2021 10:09
@robinmetral robinmetral requested review from amelako and removed request for a team November 9, 2021 10:09
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1261 (e523305) into main (a3c0412) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         184      184           
  Lines        3630     3630           
  Branches     1170     1170           
=======================================
  Hits         3341     3341           
  Misses        271      271           
  Partials       18       18           

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Storybook docs are also outdated, @giedoka fixed this in #1260

@robinmetral
Copy link
Contributor Author

Looks like the Storybook docs are also outdated, @giedoka fixed this in #1260

Yes we talked about that together 🙂 just updating this as well because a few teams mentioned it was missing from the migration guide

@robinmetral robinmetral merged commit d683896 into main Nov 9, 2021
@robinmetral robinmetral deleted the update-migration-guide branch November 9, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants