Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add border-radius changes to v3 migration guide #1261

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Add border-radius changes to v3 migration guide #1261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e1a6f8
Add border-radius changes to v3 migration guide
Nov 9, 2021
e523305
em dashes <3
Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,19 @@ Here's an overview of how the component heights have changed:

We recommend verifying these changes visually at the end of the migration.

In addition to its increased height, the `Button`'s default size was renamed from `mega` to `giga` to align it with the new size values (see the table above). (_🤖 \_button-default-size_)
In addition to its increased height, the `Button`'s default size was renamed from `mega` to `giga` to align it with the new size values (see the table above). (🤖 _button-default-size_)

### Other changes

- The design tokens **borderRadius** scale was changed. (🤖 _theme-border-radius_)
| value | v2 name | v3 name |
| --- | --- | --- |
| 1px | `kilo` | — (remove the radius or hardcode) |
| 4px | `mega` | `bit` |
| 6px | `giga` | — (migrate to `byte`) |
| 8px | `tera` | `byte` |
| 12px | `peta` | `kilo` |
| 16px | — | `mega` (new value) |
- The **NotificationBanner** component has been renamed to **NotificationCard**. (🤖 _component-names-v3_)
- Label prop names across components were harmonized to follow the _<description>Label_ pattern. (🤖 _label-prop-names_)
- **CardHeader**: `labelCloseButton` 👉 `closeButtonLabel`
Expand Down