Allow IconButton to receive loading props

[vascofg]

Purpose

Allow IconButton to display a loading state.

Approach and changes

Update types to allow isLoading and loadingLabel props for IconButton.
The behaviour already works from the parent Button component.

Definition of done

• Development completed
• Reviewers assigned
• Unit and integration tests
• Meets minimum browser support
• Meets accessibility requirements

[sumup-clark]

Hey @vascofg,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
oss-circuit-ui	✅ Ready (Inspect)	Visit Preview	May 10, 2022 at 6:43PM (UTC)

[changeset-bot]

🦋 Changeset detected

Latest commit: cc32272

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sumup/circuit-ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sumius]

Good to me!

[codecov]

Codecov Report

Merging #1570 (cc32272) into main (3f32536) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   92.71%   92.71%           
=======================================
  Files         194      194           
  Lines        4024     4024           
  Branches     1262     1262           
=======================================
  Hits         3731     3731           
  Misses        274      274           
  Partials       19       19           

Impacted Files	Coverage Δ
...es/circuit-ui/components/IconButton/IconButton.tsx	88.88% <ø> (ø)

[robinmetral]

Hey @vascofg, thanks for the PR! Can you explain what you're trying to achieve a bit more? Since the prop types extend ButtonProps, as you mentioned, the loading state should already be supported. Isn't it?

[vascofg]

Hey @vascofg, thanks for the PR! Can you explain what you're trying to achieve a bit more? Since the prop types extend ButtonProps, as you mentioned, the loading state should already be supported. Isn't it?

Hey @robinmetral, yes it is supported and it works, but generates a typescript error because the isLoading and the loadingLabel props are not allowed (marked as never).

So my PR does not change any implementation data, just updates the types.

[robinmetral]

Ah my bad, somehow I misread this as removing the loading state 🤦 makes sense to me, let's

[robinmetral]

@vascofg just tweaked the changeset a bit, I'll let you press the big green button and then handle the new version release 🙂