Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IconButton to receive loading props #1570

Merged
merged 4 commits into from
May 17, 2022
Merged

Allow IconButton to receive loading props #1570

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99f534c
allow isLoading in IconButton
vascofg May 5, 2022
eb05e73
add changeset
vascofg May 5, 2022
fc6e6ea
Merge branch 'main' of https://github.com/sumup-oss/circuit-ui into f…
vascofg May 10, 2022
cc32272
Tweak changeset
May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-buttons-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sumup/circuit-ui': patch
---

Allow IconButton to have a loading state
robinmetral marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 0 additions & 2 deletions packages/circuit-ui/components/IconButton/IconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ export interface IconButtonProps extends Omit<ButtonProps, 'icon' | 'stretch'> {
* on hover, and accessible to screen readers.
*/
label: string;
isLoading?: never;
loadingLabel?: never;
}

const Label = styled('span')(hideVisually);
Expand Down