Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration instructions for legacy Tooltip #2480

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Apr 2, 2024

Relates to #2393 and #2467.

Approach and changes

  • Gracefully handle envs that don't support :focus-visible
  • Add migration instructions

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Apr 2, 2024

⚠️ No Changeset found

Latest commit: befc0a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 0:18am

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.69%. Comparing base (0610dd8) to head (befc0a4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2480      +/-   ##
==========================================
- Coverage   87.69%   87.69%   -0.01%     
==========================================
  Files         198      198              
  Lines       21173    21182       +9     
  Branches     1276     1277       +1     
==========================================
+ Hits        18568    18575       +7     
- Misses       2553     2555       +2     
  Partials       52       52              
Files Coverage Δ
...s/circuit-ui/components/legacy/Tooltip/Tooltip.tsx 100.00% <100.00%> (ø)
packages/circuit-ui/components/Tooltip/Tooltip.tsx 97.36% <75.00%> (-0.71%) ⬇️

@connor-baer connor-baer marked this pull request as ready for review April 4, 2024 12:16
@connor-baer connor-baer requested a review from a team as a code owner April 4, 2024 12:16
@connor-baer connor-baer merged commit 2414c37 into canary Apr 4, 2024
9 of 12 checks passed
@connor-baer connor-baer deleted the feature/tooltip-migration branch April 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant