Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Tooltip component #2393

Merged
merged 23 commits into from
Mar 25, 2024
Merged

Add experimental Tooltip component #2393

merged 23 commits into from
Mar 25, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jan 17, 2024

Closes #1676.

Purpose

The legacy Tooltip component has critical accessibility issues that cannot be addressed with its current API (see #1676). This pull request adds an experimental Tooltip component which displays additional information upon hover or focus that is contextual, helpful, and nonessential to clarify the purpose of otherwise ambiguous interactive elements.

A follow-up pull request will add an experimental Toggletip component.

Approach and changes

  • Implemented an experimental Tooltip component
  • Adopted the Tooltip component for the IconButton, Pagination and Table's SortArrow components

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Copy link

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: 70ade88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sumup/circuit-ui Minor
@sumup/astro-template-circuit-ui Patch
@sumup/eslint-plugin-circuit-ui Major
@sumup/remix-template-circuit-ui Patch
next-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:03pm

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 93.48371% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 87.49%. Comparing base (6989d2e) to head (70ade88).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2393      +/-   ##
==========================================
+ Coverage   87.42%   87.49%   +0.06%     
==========================================
  Files         195      197       +2     
  Lines       20521    20795     +274     
  Branches     1220     1248      +28     
==========================================
+ Hits        17941    18195     +254     
- Misses       2529     2548      +19     
- Partials       51       52       +1     
Files Coverage Δ
packages/circuit-ui/components/Button/base.tsx 91.76% <100.00%> (-0.83%) ⬇️
...es/circuit-ui/components/ImageInput/ImageInput.tsx 90.09% <100.00%> (+0.06%) ⬆️
...onents/Pagination/components/PageList/PageList.tsx 100.00% <100.00%> (ø)
packages/circuit-ui/components/Popover/Popover.tsx 99.73% <100.00%> (+<0.01%) ⬆️
...omponents/Table/components/SortArrow/SortArrow.tsx 100.00% <100.00%> (ø)
packages/circuit-ui/components/Tag/Tag.tsx 95.90% <100.00%> (+0.07%) ⬆️
...s/circuit-ui/components/legacy/Tooltip/Tooltip.tsx 100.00% <100.00%> (ø)
...ckages/circuit-ui/components/Button/IconButton.tsx 98.62% <98.18%> (+3.30%) ⬆️
packages/circuit-ui/components/Tooltip/Tooltip.tsx 97.92% <97.92%> (ø)
packages/circuit-ui/experimental.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@connor-baer connor-baer changed the base branch from main to canary March 25, 2024 13:00
@connor-baer connor-baer marked this pull request as ready for review March 25, 2024 13:01
@connor-baer connor-baer requested a review from a team as a code owner March 25, 2024 13:01
@connor-baer connor-baer merged commit c5374e0 into canary Mar 25, 2024
11 of 12 checks passed
@connor-baer connor-baer deleted the feature/tooltip branch March 25, 2024 13:14
@connor-baer connor-baer changed the title Add Tooltip component Add experimental Tooltip component Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement the Tooltip component using Floating UI
1 participant