-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert using the experimental Tooltip component in stable components #2489
Conversation
🦋 Changeset detectedLatest commit: 0b57691 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 761ef32.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
==========================================
- Coverage 87.72% 87.68% -0.05%
==========================================
Files 198 198
Lines 21241 21209 -32
Branches 1287 1281 -6
==========================================
- Hits 18634 18597 -37
- Misses 2555 2560 +5
Partials 52 52
|
This reverts some commits from #2393.
Purpose
Using the experimental Tooltip component in stable components has turned out to be a mistake. Especially the widely-used IconButton has surfaced many edge cases and clashes with existing custom tooltips.
Approach and changes
Definition of done