Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected query into location #356

Merged
merged 3 commits into from
Oct 7, 2019

Conversation

codejockie
Copy link
Contributor

This pull request adds the query object to location. This is useful when a user needs to access the value(s) in the search/query string without having to parse the search string themself.

@codejockie codejockie closed this Oct 5, 2019
@codejockie codejockie deleted the add-query-to-location branch October 5, 2019 08:29
@codejockie codejockie restored the add-query-to-location branch October 5, 2019 08:30
@codejockie codejockie reopened this Oct 5, 2019
src/reducer.js Outdated Show resolved Hide resolved
src/reducer.js Outdated Show resolved Hide resolved
src/reducer.js Outdated Show resolved Hide resolved
src/reducer.js Outdated Show resolved Hide resolved
Copy link
Owner

@supasate supasate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Only fix the coding style and it'll be good to go.

@codejockie codejockie force-pushed the add-query-to-location branch from 4eaf9a2 to e91df39 Compare October 6, 2019 09:05
@codejockie
Copy link
Contributor Author

@supasate I have fixed the code style.

@codejockie codejockie requested a review from supasate October 6, 2019 09:17
@supasate supasate merged commit 776c295 into supasate:master Oct 7, 2019
@supasate
Copy link
Owner

supasate commented Oct 7, 2019

@codejockie Thanks so much for your contribution!

@storrella
Copy link

@supasate do you plan to build a release including these changes?

@sethomas
Copy link

#376

@VadimKorobka
Copy link
Contributor

I use it with ElectronJS. Thanks for the lovely Monday morning with crash my application.

ReferenceError: window is not defined
    at injectQuery

@VadimKorobka
Copy link
Contributor

I can fix this error and create PR if no one objects and does not do it now? @codejockie @supasate

@codejockie
Copy link
Contributor Author

codejockie commented Nov 18, 2019

I can fix this error and create PR if no one objects and does not do it now? @codejockie @supasate

@KorobkaVadim I was thinking of doing that. Since you are already interested, you can go ahead.

@VadimKorobka
Copy link
Contributor

#377

@sixertoy
Copy link

Hello :)
Seems like it was not a good need in my case.
I've got to manage URL from a third party app, and this URL contains a parameter called query so... voilà voilà :)
May be could we have an option to disable this query parameter ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants