-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash outside browser environment #377
Conversation
@supasate Pls, check and bump version, it's very hot changes. |
#376 Fix |
@codejockie any update on this, when is this going to be merge and released? |
This eliminates valid server-side handling of initial router dispatches in connected redux stores. It was previously possible to process any valid passed Location instance server-side without the need to short-circuit the reducer. It’d be a more complete fix to remove the unnecessary check against |
@KorobkaVadim could you update this PR according to what @rmunson said above? |
Yeah. You are right, I saw this, but these are not my changes. This PR was a hotfix, but something is getting cold. I will fix it in two hours.Thank you! |
@codejockie @rmunson Done, pls check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I appreciate the adjustment.
Should still be functional minus the fallback.
@supasate Pls, check this PR, because a lot of people wait this fix. @codejockie and @rmunson approved these changes. |
Is there any movement on this PR being released?. As a server rendered application we are basically locked down until this fix is out in the wild. Thanks so much! |
LGTM. Appreciate everyone for the hot fix. I'm releasing it soon. By the way, it may be a good idea to have a test for server side environment to prevent any future break. Appreciate any contribution in advanced! |
* 'master' of github.com:supasate/connected-react-router: fix: crash outside browser environment (#377)
No description provided.