avoid opening preview on focus when item is already selected #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDESK-6777 SDNTB-784
|
Instead of handling it inside |
|
it's actually focus called on the item, it only happens when the item is locked so the focus doesn't go to authoring, then when the window is revisited the previously focused item gets the focus again |
|
I didn't see the video previously, now I understand the issue. Maybe make a comment more clear by specifying that by " returning to same screen" you mean browser tab changes and browser behavior of focusing element again. |
tomaskikutis
approved these changes
Jan 4, 2023
petrjasek
added a commit
that referenced
this pull request
Jan 11, 2023
* avoid opening preview on focus when item is already selected SDESK-6777 SDNTB-784
petrjasek
added a commit
that referenced
this pull request
Feb 1, 2023
* avoid opening preview on focus when item is already selected SDESK-6777 SDNTB-784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-6777 SDNTB-784