Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid opening preview on focus when item is already selected #4172

Merged
merged 3 commits into from
Jan 4, 2023
Merged

avoid opening preview on focus when item is already selected #4172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93a51ac
avoid opening preview on focus when item is already selected
petrjasek Jan 3, 2023
bb0a31c
fix lint
petrjasek Jan 3, 2023
15c16f2
tweak comment
petrjasek Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/apps/search/components/ItemList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ export class ItemList extends React.Component<IProps, IState> {
return;
}

if (event.type === 'focus' && item === this.getSelectedItem()) {
// when returning to browser tab focus can be triggered by browser
// and trigger select on already selected item
return;
}

if (typeof this.props.onMonitoringItemSelect === 'function') {
this.props.onMonitoringItemSelect(item, event);
return;
Expand Down