use full paths when calling exec command #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting relative paths in PATH is bad. Go changed the behavior as you noted. Rust did it too in rust-lang/rust#87704. Is to coming from customers' own configuration (like ~/.bashrc) or tools (like Bundler)? |
|
Putting relative paths in PATH is commonplace for Ruby. Example: https://github.com/rbenv/rbenv/wiki/Understanding-binstubs#adding-project-specific-binstubs-to-path ; note the security concern mentioned on that page. |
kzys
requested changes
Jun 13, 2023
|
Oh rbenv... |
kzys
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://tip.golang.org/doc/go1.19#os-exec-path
https://community.fly.io/t/unable-to-run-flyctl-launch/13504