Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error messages when the authpage has issues covering all factors #846

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

Added a more detailed error message in cases where we have more specific info.

Related issues

Test Plan

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
lib/build/index.js 22.57 KB (+1.2% 🔺)
recipe/session/index.js 23.34 KB (+1.27% 🔺)
recipe/session/prebuiltui.js 27.76 KB (+1.12% 🔺)
recipe/thirdparty/index.js 31.33 KB (0%)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (0%)
recipe/passwordless/index.js 14.76 KB (0%)
recipe/emailverification/prebuiltui.js 32.42 KB (+0.85% 🔺)
recipe/thirdparty/prebuiltui.js 50.96 KB (+0.53% 🔺)
recipe/emailpassword/prebuiltui.js 38.52 KB (+0.8% 🔺)
recipe/passwordless/prebuiltui.js 125.7 KB (+0.23% 🔺)
recipe/multitenancy/index.js 6.67 KB (0%)
recipe/multifactorauth/index.js 10.77 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.35 KB (+1.17% 🔺)

@@ -368,6 +372,11 @@ async function buildAndSetChildProps(
(!SuperTokens.usesDynamicLoginMethods || loadedDynamicLoginMethods!.thirdparty.providers.length === 0)
) {
firstFactors = firstFactors.filter((f) => f !== FactorIds.THIRDPARTY);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the user was seeing a different error message like frontend doesn't cover all factors or something. I think wherever that message is, that message can also be improved to state exactly which factors are coming from the backend, and which ones are on the frontend, and which ones are missing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That case should be caught earlier by what I added (so we can show a more specific error message), but I also tried to extend the existing one with what the first factors are, where we got the list from and what we have available.

@porcellus porcellus merged commit b6f4657 into master Aug 11, 2024
23 of 27 checks passed
@porcellus porcellus deleted the fix/improve_firstfactor_error_msg branch August 11, 2024 23:07
@porcellus porcellus restored the fix/improve_firstfactor_error_msg branch August 11, 2024 23:16
@porcellus porcellus mentioned this pull request Aug 11, 2024
13 tasks
@rishabhpoddar rishabhpoddar deleted the fix/improve_firstfactor_error_msg branch August 12, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants