Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve firstfactor error msg #849

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

re-creating #846 after wrong merge.

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Remaining TODOs for this PR

  • Item1
  • Item2

Copy link

size-limit report 📦

Path Size
lib/build/index.js 22.57 KB (+1.2% 🔺)
recipe/session/index.js 23.34 KB (+1.27% 🔺)
recipe/session/prebuiltui.js 27.76 KB (+1.12% 🔺)
recipe/thirdparty/index.js 31.33 KB (0%)
recipe/emailpassword/index.js 11.07 KB (0%)
recipe/emailverification/index.js 7.84 KB (0%)
recipe/passwordless/index.js 14.76 KB (0%)
recipe/emailverification/prebuiltui.js 32.42 KB (+0.85% 🔺)
recipe/thirdparty/prebuiltui.js 50.96 KB (+0.53% 🔺)
recipe/emailpassword/prebuiltui.js 38.52 KB (+0.8% 🔺)
recipe/passwordless/prebuiltui.js 125.7 KB (+0.23% 🔺)
recipe/multitenancy/index.js 6.67 KB (0%)
recipe/multifactorauth/index.js 10.77 KB (0%)
recipe/multifactorauth/prebuiltui.js 31.35 KB (+1.17% 🔺)

@rishabhpoddar rishabhpoddar merged commit 27e6541 into 0.45 Aug 12, 2024
47 of 54 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/improve_firstfactor_error_msg branch August 12, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants