fix: multitenant user association with account linking #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
requested changes
Aug 30, 2023
| @@ -777,22 +779,41 @@ public static String lockEmailAndTenant_Transaction(Start start, Connection con, | |||
| }); | |||
| } | |||
|
|
|||
| public static String lockPhoneAndTenant_Transaction(Start start, Connection con, | |||
| TenantIdentifier tenantIdentifier, | |||
| public static List<String> lockEmailAndTenant_Transaction(Start start, Connection con, AppIdentifier appIdentifier, | |||
| }); | ||
| } | ||
|
|
||
| public static List<String> lockPhoneAndTenant_Transaction(Start start, Connection con, |
| @@ -777,22 +779,41 @@ public static String lockEmailAndTenant_Transaction(Start start, Connection con, | |||
| }); | |||
| } | |||
|
|
|||
| public static String lockPhoneAndTenant_Transaction(Start start, Connection con, | |||
| TenantIdentifier tenantIdentifier, | |||
| public static List<String> lockEmailAndTenant_Transaction(Start start, Connection con, AppIdentifier appIdentifier, | |||
There was a problem hiding this comment.
there is still a function called lockEmailAndTenant_Transaction that takes tenant Identifier
| public static boolean addUserIdToTenant_Transaction(Start start, Connection sqlCon, | ||
| TenantIdentifier tenantIdentifier, String userId) | ||
| throws StorageQueryException, SQLException { | ||
| throws StorageQueryException, SQLException, DuplicateEmailException, DuplicatePhoneNumberException { | ||
| UserInfoPartial userInfo = PasswordlessQueries.getUserById(start, sqlCon, | ||
| tenantIdentifier.toAppIdentifier(), userId); | ||
|
|
There was a problem hiding this comment.
this logic goes in the core.
This was referenced Sep 7, 2023
rishabhpoddar
added a commit
that referenced
this pull request
Sep 20, 2023
* up to speed iwth in mem db * bug fix * adds link account function * removes unneeded index * Account linking function changes (#136) * fixes bugs * more tests * Link accounts (#137) * fixes bugs * more tests * updates to function (#138) * Account linking unlink accounts (#139) * updates to function * adds unlink account function * fixes and adds test (#140) * changes for password reset flow (#141) * Account linking update email (#142) * changes for password reset flow * removes unneeded function * removes unneeded function * adds recipe user id in session (#143) * fixes query (#144) * fix: user pagination (#145) * fix: query update * fix: primary_or_recipe_user_time_joined added to all_auth_users table * fix: primary_or_recipe_user_time_joined added to all_auth_users table * fix: user pagination queries * fix: user pagination queries * fix: plugin interface fix (#146) * fix: plugin interface fix * fix: pr comments * fix: pr comments * fix: External userid (#147) * fix: plugin interface fix * fix: pr comments * fix: pr comments * fix: external userid * fix: remove UserInfo class (#148) * fix: multitenant user association with account linking (#149) * fix: tenant association query fixes * fix: multitenancy related changes * fix: pr comments * fix: pr comments * fix: pr comments * fix: remove con reuse (#150) * fix: remove con reuse * fix: pr comments * fix: pr comments * fix: pr comments * fix: pr comments * fix: index updates (#152) * fix: updated indexes * fix: pr comments * fix: pr comments * fix: fkey constraint for primary_or_recipe_user_id (#153) * fix: account linking stats (#154) * fix: account linking stats * fix: query * fix: pr comment * fix: fixing tenant association * fix: allow user disassociation from all tenant (#156) * fix: allow user disassociation from all tenant * fix: query * fix: useridmapping functions (#157) * fix: version and changelog * fix: version and changelog * fix: time joined fix --------- Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com> Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add them inimplementationDependencies.json.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR