-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: index updates #152
fix: index updates #152
Conversation
+ "(primary_or_recipe_user_time_joined DESC, primary_or_recipe_user_id DESC, tenant_id DESC, app_id DESC);"; | ||
static String getQueryToCreateUserPaginationIndex1(Start start) { | ||
return "CREATE INDEX all_auth_recipe_users_pagination_index1 ON " + Config.getConfig(start).getUsersTable() | ||
+ "(app_id, tenant_id, primary_or_recipe_user_time_joined DESC, primary_or_recipe_user_id DESC);"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -102,30 +102,44 @@ public static String getQueryToCreateTenantIdIndexForUsersTable(Start start) { | |||
+ Config.getConfig(start).getUsersTable() + "(app_id, tenant_id);"; | |||
} | |||
|
|||
static String getQueryToCreateUserPaginationIndex(Start start) { | |||
return "CREATE INDEX all_auth_recipe_users_pagination_index ON " + Config.getConfig(start).getUsersTable() | |||
+ "(primary_or_recipe_user_time_joined DESC, primary_or_recipe_user_id DESC, tenant_id DESC, app_id DESC);"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add psql prs to this checklist: supertokens/supertokens-core#742 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Config.getConfig(start).getUsersTable() | ||
+ "(app_id, tenant_id, primary_or_recipe_user_id);"; | ||
+ "(recipe_id, app_id, tenant_id);"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ "(recipe_id, app_id, tenant_id);"; | |
+ "(app_id, recipe_id, tenant_id);"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
* up to speed iwth in mem db * bug fix * adds link account function * removes unneeded index * Account linking function changes (#136) * fixes bugs * more tests * Link accounts (#137) * fixes bugs * more tests * updates to function (#138) * Account linking unlink accounts (#139) * updates to function * adds unlink account function * fixes and adds test (#140) * changes for password reset flow (#141) * Account linking update email (#142) * changes for password reset flow * removes unneeded function * removes unneeded function * adds recipe user id in session (#143) * fixes query (#144) * fix: user pagination (#145) * fix: query update * fix: primary_or_recipe_user_time_joined added to all_auth_users table * fix: primary_or_recipe_user_time_joined added to all_auth_users table * fix: user pagination queries * fix: user pagination queries * fix: plugin interface fix (#146) * fix: plugin interface fix * fix: pr comments * fix: pr comments * fix: External userid (#147) * fix: plugin interface fix * fix: pr comments * fix: pr comments * fix: external userid * fix: remove UserInfo class (#148) * fix: multitenant user association with account linking (#149) * fix: tenant association query fixes * fix: multitenancy related changes * fix: pr comments * fix: pr comments * fix: pr comments * fix: remove con reuse (#150) * fix: remove con reuse * fix: pr comments * fix: pr comments * fix: pr comments * fix: pr comments * fix: index updates (#152) * fix: updated indexes * fix: pr comments * fix: pr comments * fix: fkey constraint for primary_or_recipe_user_id (#153) * fix: account linking stats (#154) * fix: account linking stats * fix: query * fix: pr comment * fix: fixing tenant association * fix: allow user disassociation from all tenant (#156) * fix: allow user disassociation from all tenant * fix: query * fix: useridmapping functions (#157) * fix: version and changelog * fix: version and changelog * fix: time joined fix --------- Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com> Co-authored-by: Mihály Lengyel <mihaly@lengyel.tech>
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.json
file has been updated (if needed)build.gradle
build.gradle
, please make sure to add them inimplementationDependencies.json
.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR