Building ubuntu and debian inside docker #115
Conversation
|
Everything appears to be building 🎉 thanks @bam241 for getting this started |
…:svalinn/Cubit-plugin into building_ubuntu_and_debian_inside_docker
|
I've addressed all the suggestions and done as recommended, thanks for the review. Let's see how it does with the CI building process. |
Sounds like a good plan, I think once GH actions allows containers of Mac OS there is some recombination that can be done |
|
There some issues with the plug-in artifacts uploads: https://github.com/svalinn/Cubit-plugin/actions/runs/1114012215 https://github.com/svalinn/Cubit-plugin/actions/runs/1114012218 One also can test those individually to ensure they are working as intended :) |
|
I meant test them locally |
This is very unlikely to happen as it will broken general usage conditions of MacOS: you can only use macOS on a Mac machine... |
Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>
| } | ||
|
|
||
| function linux_install_prerequisites() { | ||
| TZ=America/Chicago | ||
| $SUDO ln -snf /usr/share/zoneinfo/$TZ /etc/localtime | ||
| $SUDO sh -c 'echo $TZ > /etc/timezone' | ||
| $SUDO apt-get update -y | ||
| $SUDO apt-get install -y g++ libeigen3-dev patchelf git cmake curl lsb-release python3 lsb-core | ||
| if [ "$OS" == "ubuntu" ]; then | ||
| $SUDO apt-get install -y g++ libeigen3-dev patchelf git cmake curl lsb-release python3 lsb-core |
There was a problem hiding this comment.
Notice that this script relies on SUDO but it never gets set. Current behavior is probably that this resolves to nothing and doesn't matter... but we should either remove the $SUDO here, or set the variable as appropriate.
There was a problem hiding this comment.
I've now set SUDO to an empty string in the mac and linux github actions scripts in commit 6dc6a66
There was a problem hiding this comment.
Ah that setting of SUDO to an empty string appears to have not worked
added os_version to unix build macro
Co-authored-by: Baptiste Mouginot <15145274+bam241@users.noreply.github.com>
|
Looks like Trelis 17.1.0 is failing on Ubuntu 21.04 due to not finding HDF5
This was not actually build previously so I shall add it to the exclude list. Perhaps it is fair to exclude combinations of old cubit with new os or vice versa Ubuntu 20.04 with Cubit 17.0.1 was previously excluded, so I think it is reasonable to also exclude 21.04 with this version of Cubit |
|
Builds are passing for all the combinations 🎉 |
|
Thanks @shimwell - this gives us a good starting point to refine and grow |
Following on from the last DAGMC meeting here is a PR that attempts to build the plugin for debian 10.10
The approach taken is to use a docker container to build linux flavours (ubuntu 21.04, ubuntu 20.04, debian 10.10) and to use the base github actions (without a docker container) to build for mac os.
This appears to work given the constraints:
This appears to help with #112 as the plugin can be build for a few more OS and OS versions.