Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building ubuntu and debian inside docker #115
Building ubuntu and debian inside docker #115
Changes from 12 commits
91c017d
7e8acb0
add0e6d
5fa3236
df9f994
ee908bb
74a9fc9
11004ff
61cfc42
bb0fed3
e3d1603
9ca5be2
c240997
ea85835
e634ff8
63cd0ae
24534f2
06ce7c6
6dc6a66
1eb8739
8cb3fdc
90feb37
089a9ad
631f97d
c29347b
9b5daa1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that this script relies on
SUDO
but it never gets set. Current behavior is probably that this resolves to nothing and doesn't matter... but we should either remove the$SUDO
here, or set the variable as appropriate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now set SUDO to an empty string in the mac and linux github actions scripts in commit 6dc6a66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that setting of SUDO to an empty string appears to have not worked