Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgraded unittests to ESLint 8.x #142

Closed
wants to merge 1 commit into from

Conversation

bfanger
Copy link
Contributor

@bfanger bfanger commented Nov 5, 2021

CLIEngine is removed in ESLint 8
https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0

I've updated the tests and wrapped it in a async function (lintFiles is asynchronous)

Another fix to running the tests would be to modify the package.json:
change "eslint": ">=6.0.0", into "eslint": ">=6.0.0 <8",
(aka limit the eslint version to 7.x)

@dummdidumm
Copy link
Member

dummdidumm commented Jan 3, 2022

Thanks. I decided to merge #155 which takes another approach by limiting this to eslint < 8. Reason: This plugin supports ESLint 6+ and with ESLint 8 used in dev we might accidentally introduce a breaking change if we bump to 8 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants