Use TS 4.5 preserveValueImports if it's available
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears I need to rewrite the test runner... ESLint doesn't seem to support that synchronous API anymore. |
|
Okay, done. Supporting old Node is a pain, man. |
|
Could you explain what is the difference to #142 with regards to the eslint bump? For example why is the |
|
My memory is already fuzzy lol but I'm pretty sure With the ESLint versioning, it has to do with the supported Node versions. Tests will fail with ESLint 8 because it's not compatible. |
dummdidumm
approved these changes
Jan 3, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
Closes #142
I also updated the package's dev-dependencies to use the latest TypeScript stuff. I did this so that I could add a test for checking if the inline type import syntax works.