-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v2 migration helpers #11199
feat: v2 migration helpers #11199
Conversation
|
I think we were a little inconsistent in the language of some of the changesets. Maybe we can align them as part of this. Especially |
I think it'd be nice for this to appear before "Migrating from Sapper" in the sidebar since it will be relevant to more users. And maybe we can call it "Migrating to SvelteKit v2" rather than "Migration to SvelteKit v2" for consistency, so that both entries begin with "Migrating" |
} | ||
|
||
/** @param {string} content */ | ||
export function update_tsconfig_content(content) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also make sure typescript is on v5 and that moduleResolution
is bundler
for applications and NodeNext
or Node16
for libraries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK NodeNext is already used for libs for a while already, but we can set bundler if we see nothing is set, or better yet remove the setting entirely.
Typescript should already be ^5.0 through the Svelte 4 upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. One thing to note is that the v2 branch sets it to NodeNext
when running package
, which isn't done on master
, but it's kind of weird because it might not match what's in the tsconfig.json
. Maybe we should have package
check if that's the value contained in the tsconfig.json
?
Merging now and doing the other changes in their respective PRs sounds good.
|
Am trying to insert I've wasted enough time fighting with it and there are more important things to do, so I'm just doing to check in my work so far and merge this PR. Those other changes can be follow-ups. |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.