chore: fix cookie migration hints, and also disable them #11262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie migration hints added in #11199 were broken — they didn't change anything in the SvelteKit demo app, because the ancestor check only cared about arrow function expressions that were assigned to a variable. Fixing the ancestor check revealed a separate bug — we need to batch up the changes, otherwise we get an error like this:
By collecting the nodes that need to be commented first, and then commenting them, the operation succeeds, but it leaves us with stupid-looking whitespace that's inconsistent with the surroundings:
If we can fix that, great, otherwise I really think we're better off relying on the combination of type and runtime errors here. It's just not worth it.