Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump eslint from version 7 to 8 #4553

Merged
merged 2 commits into from
May 5, 2022
Merged

[chore] bump eslint from version 7 to 8 #4553

merged 2 commits into from
May 5, 2022

Conversation

stvnwn
Copy link
Contributor

@stvnwn stvnwn commented Apr 7, 2022

When a user creates a SvelteKit app with eslint support using create-svelte, it ships the last eslint release under major version 7. With this pull request, create-svelte will now ship the latest eslint release (for now).

I'm worried that eslint-plugin-svelte3 doesn't support eslint@^8.0.0, from this discussion.

eslint-plugin-svelte3's peerDependencies lists eslint@>=6.0.0 since June 22, 2019, around when eslint@6.0.1 was released.

Related: #3261


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: 2bd4f9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

I think we should first release a new major for eslint-plugin-svelte3 which officially supports ESLint 8, drops NodeJS 10 support etc and then continue here. @Conduitry would you be ok with that?

@Conduitry
Copy link
Member

That sounds fine to me. Is there any benefit to dropping Node 12 while we're at it, because it's EOL at the end of the month anyway?

@benmccann benmccann changed the title [pkg:create-svelte] Bump eslint from version 7 to 8 [chore] bump eslint from version 7 to 8 Apr 11, 2022
@benmccann
Copy link
Member

The eslint plugin tests currently use an internal eslint class. eslint 8 adds an exports map that stops us from using it. I've sent eslint/eslint#15776 to unblock it.

If that doesn't work we can see if we can hack around that by doing something like require.resolve('eslint/package.json') and then constructing the path of the module we want to require since we can probably require an absolute or relative path, regardless of export maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants