Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] allow +server.js files next to +page files #6773

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 13, 2022

Closes #5896

Also added a related paragraph to "Form Actions" because I saw some people asking about this specifically.

Marking as draft because I don't know what to make of this TODO:

type: route.page ? 'page' : 'endpoint', // TODO change this if support pages+endpoints

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

🦋 Changeset detected

Latest commit: c29b546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
dummdidumm and others added 3 commits September 15, 2022 09:48
@@ -195,7 +195,7 @@ export interface RequestOptions {

export interface RouteDefinition {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside: it's strange to me that this is private API - it's public because it's part of the public builder methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back support for content negotiation (allow +page.svelte & +server.ts to co-exist)
3 participants