-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] allow +server.js files next to +page files #6773
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
95c9eef
[feat] allow +server.js files next to +page files
dummdidumm 285f10b
Update packages/kit/src/runtime/server/endpoint.js
dummdidumm b2afb03
simplify rules and document them
dummdidumm 4ec480b
adjust builder type
dummdidumm 00d37d9
Update documentation/docs/06-form-actions.md
dummdidumm 06d14b6
link
dummdidumm cf485b1
merge master
Rich-Harris c59a27e
remove unused type
dummdidumm 071213a
Merge branch 'server-next-to-page' of https://github.com/sveltejs/kit…
dummdidumm c29b546
move docs to +server.js section
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': patch | ||
--- | ||
|
||
[feat] allow +server.js files next to +page files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
packages/kit/test/apps/basics/src/routes/routing/endpoint-next-to-page/+page.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<script> | ||
let result; | ||
|
||
/** @param {string} method */ | ||
async function request(method) { | ||
result = 'loading'; | ||
const response = await fetch('/routing/endpoint-next-to-page', {method}); | ||
result = await response.text(); | ||
} | ||
</script> | ||
|
||
<p>Hi</p> | ||
<button on:click={() => request('GET')}>GET</button> | ||
<button on:click={() => request('PUT')}>PUT</button> | ||
<button on:click={() => request('PATCH')}>PATCH</button> | ||
<button on:click={() => request('POST')}>POST</button> | ||
<button on:click={() => request('DELETE')}>DELETE</button> | ||
<pre>{result}</pre> |
24 changes: 24 additions & 0 deletions
24
packages/kit/test/apps/basics/src/routes/routing/endpoint-next-to-page/+server.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** @type {import('./$types').RequestHandler} */ | ||
export function GET() { | ||
return new Response('GET'); | ||
} | ||
|
||
/** @type {import('./$types').RequestHandler} */ | ||
export function PUT() { | ||
return new Response('PUT'); | ||
} | ||
|
||
/** @type {import('./$types').RequestHandler} */ | ||
export function PATCH() { | ||
return new Response('PATCH'); | ||
} | ||
|
||
/** @type {import('./$types').RequestHandler} */ | ||
export function POST() { | ||
return new Response('POST'); | ||
} | ||
|
||
/** @type {import('./$types').RequestHandler} */ | ||
export function DELETE() { | ||
return new Response('DELETE'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside: it's strange to me that this is private API - it's public because it's part of the public builder methods