Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transitions inside components #1188

Closed
EmilTholin opened this issue Feb 24, 2018 · 4 comments · Fixed by #1210
Closed

Transitions inside components #1188

EmilTholin opened this issue Feb 24, 2018 · 4 comments · Fixed by #1210
Labels
bug

Comments

@EmilTholin
Copy link
Member

Transitions works great in regular markup, but doesn't seem to have any effect inside a component, like this basic repro illustrates.

I apologize if this is the intended behavior, but I could only find information about putting a transition on the actual component itself.
ekhaled added a commit to ekhaled/svelte that referenced this issue Mar 6, 2018
@ekhaled
fixes sveltejs#1188, fixes sveltejs#1201
e2d5061
@ekhaled ekhaled mentioned this issue Mar 6, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 6, 2018
@Rich-Harris
Merge pull request #1210 from ekhaled/some_fixes
6ea1612 
fixes #1188, fixes #1201
@Rich-Harris
Copy link
Member

released 1.56.3 with the fix — thanks 👍

@EmilTholin
Copy link
Member Author

Awesome! In-transitions works great, but out-transitions seem to have some problems still.

cc @ekhaled

@ekhaled
Copy link
Contributor

ekhaled commented Mar 11, 2018

There is an issue open for that #1211

@EmilTholin
Copy link
Member Author

Ah, sorry about that. Thanks.

This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #1188, fixes #1201 ekhaled/svelte
3 participants
@ekhaled @Rich-Harris @EmilTholin