Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use _mount, even if top-level #1201

Closed
Rich-Harris opened this issue Mar 4, 2018 · 0 comments · Fixed by #1210
Closed

always use _mount, even if top-level #1201

Rich-Harris opened this issue Mar 4, 2018 · 0 comments · Fixed by #1210

Comments

@Rich-Harris
Copy link
Member

Using this._mount(target, anchor) instead of this._fragment.m(target, anchor) would fix sveltejs/svelte-loader#43. Using a private _mount method like this is arguably a bit of a hack, and we could discuss whether we need to make it a public method for the sake of things like this, but for now it's an easy way to get granular HMR working.
ekhaled added a commit to ekhaled/svelte that referenced this issue Mar 6, 2018
@ekhaled
fixes sveltejs#1188, fixes sveltejs#1201
e2d5061
@ekhaled ekhaled mentioned this issue Mar 6, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 6, 2018
@Rich-Harris
Merge pull request #1210 from ekhaled/some_fixes
6ea1612 
fixes #1188, fixes #1201
@ekhaled ekhaled mentioned this issue Mar 7, 2018
Closed
This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #1188, fixes #1201 ekhaled/svelte
1 participant
@Rich-Harris