Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outroing transition group never unmounts if one sibling remounts with delay in bidirectional transition #4954

Closed
pushkine opened this issue Jun 2, 2020 · 3 comments
Labels

Comments

@pushkine
Copy link
Contributor

pushkine commented Jun 2, 2020

https://svelte.dev/repl/7157234039fa43c2ac779c534941e263?version=3.23.0

if (!pending_program) {
// we're done
if (running_program.b) {
// intro — we can tidy up immediately
clear_animation();
} else {
// outro — needs to be coordinated
if (!--running_program.group.r) run_all(running_program.group.c);
}
}
running_program = null;

pending_program is only present in bidirectional transitions with delay

reversing one while it's outroing will fail the !pending_program check, and discard running_program

the group running_program belongs to subsequently cannot complete its transition

orange4glace added a commit to orange4glace/svelte that referenced this issue Sep 4, 2020
orange4glace added a commit to orange4glace/svelte that referenced this issue Sep 4, 2020
@Conduitry
Copy link
Member

This should be fixed now in 3.29.0.

@pushkine
Copy link
Contributor Author

pushkine commented Oct 1, 2020

it's not, the REPL is expected to outro b after clicking the button

@orange4glace
Copy link
Contributor

orange4glace commented Oct 4, 2020

As I've seen this issue again, #5353 is not related with this issue. My apology.

#5353 fixes child component with delayed bidirectional transition prevents its parent component being unmounted.
This issue describes that parent component which has child component with delayed transition prevents its child component being unmounted.

#5353 should be stay what it was since it actually fixes the existing bug which is described in #5353,
and this issue should be reopened since #5353 does not fixes the bug described in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants