fix: #4954 Delayed bidirectional transition prevents components from unmounting #5353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orange4glace
changed the title
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce: Toggle Checkbox multiple times within a second
https://svelte.dev/repl/61d6a8c1cf8a4a819d40e44037617f44?version=3.24.1
When
running_program == null && pending_program != null(This happens becausepending_programhas a delay) and new program comes, new program is assigned torunning_programand oldpending_programremains what it was. Eventually, new program will be stopped bypending_program. Notice thatpending_programcomes before new program but it intercepts new one.If
pending_program != nulland new program comes,pending_programshould be assigned as new program