Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Getting Svelte independly grouped on GitHub #5310

Closed
outloudvi opened this issue Aug 26, 2020 · 10 comments
Closed

FR: Getting Svelte independly grouped on GitHub #5310

outloudvi opened this issue Aug 26, 2020 · 10 comments
Labels

Comments

@outloudvi
Copy link
Contributor

(This is meta-problem mainly about the community, and might be better be discussed in a community space like Discord, but I don't have an account there. Also I see stuffs like #2067 so I think it safe to bring it up here.)

Currently Svelte projects are recognized as "HTML" projects (this is outloudvi/starbuttons-next):

image

This will be confusing for other developers. What's worse, it's bad for searching (since people cannot simply filter Svelte project by language) as well as the development of Svelte community. Therefore, I think it's important to get Svelte independently grouped as a language on GitHub like Vue does.

We see that GitHub can correctly highlight .svelte files (thanks for github-linguist/linguist#4504!), but Svelte has not been independently grouped. The reason seems to be here:

Svelte:
 #...
  group: HTML
 #...

It's grouped in HTML, and as said in languages.yml, "Languages in a group are counted in the statistics as the parent language.", it's a part of HTML.

How to fix this? The solution is to get it out of the HTML group, and to do so we need to give Svelte a color different from HTML. github-linguist/linguist#4894 was a great try, but GitHub currently disallow too similar colors on their language palette (the color from Svelte logo, #ff3e00, is too close to some color on the palette). So, currently I think we can find an alternative color to represent Svelte on GitHub. To help with finding a valid color, here are some useful tools:


(I personally think #ee6600 can be one of the candidates, but there might be better choices!)

@antony antony added the meta label Aug 26, 2020
@antony
Copy link
Member

antony commented Aug 26, 2020

Absolutely agree that the group should be Svelte.

@vedam any thoughts on colour?

@pngwn
Copy link
Member

pngwn commented Aug 26, 2020

#ff43d6 is available

@pngwn
Copy link
Member

pngwn commented Aug 26, 2020

That meta label is a nice shade of purple actually.

@antony antony added the mustard label Aug 26, 2020
@pngwn
Copy link
Member

pngwn commented Aug 26, 2020

no

@antony antony removed the mustard label Aug 26, 2020
@vedam
Copy link
Member

vedam commented Aug 26, 2020

@pngwn heh, seems you're looking for a mdsvex-color. 😂
@antony the first I found with the color-picker from above that comes close was: #d14900

@pngwn
Copy link
Member

pngwn commented Aug 26, 2020

#d14900

@benmccann
Copy link
Member

I think #ff163f might be the closest I've found on the color picker

Here are some others: #a4005c #ff029e #ff063f #ff013e #e20060

@vaheqelyan
Copy link

I like the @outloudvi version. #ff3e00 the current color of svelte.

@dummdidumm
Copy link
Member

dummdidumm commented Sep 4, 2020

Seems like there were some changes (they removed the color restrictions) in the linguist repo which made Svelte an independent language and even gave it the #ff3e00 color. So I think we just have to wait a little more until this is live and then this has solved itself.

@dummdidumm
Copy link
Member

From https://github.com/sveltejs/community
image
The change is live now. For some repos it might not show it yet probably because indexing that takes time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants