-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting for svelte #4504
Conversation
As just discovered and mentioned in #4481, Travis CI doesn't support draft PRs yet, so once this is ready to go, you'll either need to push another commit after making this a real PR or we'll need to close and re-open it to trigger the build. |
This PR should be squash-merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
Could you please fill in the template? It is missing a correct link to in-the-wild search results and information on the added sample file. The Travis-CI build failure is also legit and should be addressed.
@pchaigno I've updated the PR, let me know if it's still missing anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the template, however it's missing one thing: the source of the sample file, which is also the reason I'm requesting a change on this PR. Your sample file looks like a very simple "hello world" example. No one uses "hello world" in production 😉 and they're not good for Linguist as they're terrible examples for training the classifier.
Can you please replace this with an appropriately licensed real-world example that makes a good representation of real usage, and link to the source in the template.
@lildude I've added another example. Let me know if it's still trivial, I'll ask someone from the community to add one. |
@umanghome looks good to me. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #4321 by adding syntax highlighting to .svelte files. Reopening after changes made to #4323.
Description
Checklist:
I am associating a language with a new file extension.
I am adding a new language.
TodoMVC.svelte
: UnlicensedI am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language