Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onMount when connected & clean up when disconnected for custom element #4522

Merged
merged 21 commits into from
Feb 15, 2021

Commits on Dec 18, 2019

  1. pseudo code

    hontas authored Dec 18, 2019
    Configuration menu
    Copy the full SHA
    f2eb632 View commit details
    Browse the repository at this point in the history
  2. pseudo code

    hontas authored Dec 18, 2019
    Configuration menu
    Copy the full SHA
    6ebffd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Merge branch 'master' of https://github.com/sveltejs/svelte

    * 'master' of https://github.com/sveltejs/svelte: (137 commits)
      -> v3.19.2
      fix lazy code breaks in build
      fit bitmask overflow initial dirty value in 'if' blocks (sveltejs#4507)
      add dev runtime warning for unknown slot names (sveltejs#4501)
      fix render fallback slot content due to whitespace (sveltejs#4500)
      docs: describe falsy and nullish attribute behavior (sveltejs#4498)
      in spread, distinguish never-updating and always-updating props (sveltejs#4487)
      chore: more specific typings, and add README note about Yarn (sveltejs#4483)
      update changelog
      check for unknown props even if component doesn't have writable props (sveltejs#4454)
      Bump codecov from 3.5.0 to 3.6.5 (sveltejs#4433)
      fix bitmask overflow for slot (sveltejs#4485)
      mark module variables as mutated or reassigned (sveltejs#4469)
      docs: referenced_from_script var value (sveltejs#4486)
      docs: clarify default prop behaviour (sveltejs#4460)
      site: turn fancybutton into custombutton (sveltejs#4476)
      update changelog
      exclude global variables from $capture_state (sveltejs#4475)
      -> v3.19.1
      don't treat $$-names as stores during invalidation (sveltejs#4453)
      ...
    hontas committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    7d9ff14 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. cleanup

    hontas committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    0245239 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Merge remote-tracking branch 'upstream/master'

    Pontus Lundin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    72acf15 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Merge remote-tracking branch 'upstream/master'

    Pontus Lundin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    55559e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Merge remote-tracking branch 'upstream/master'

    * upstream/master: (190 commits)
      invalidate $$props and $$restProps only when there are changes (sveltejs#5123)
      site: use https in link in blog (sveltejs#5148)
      Simplify each block bindings example (sveltejs#5094)
      fix $$props reactive for slots (sveltejs#5125)
      site: add FAQ entry for how to document a svelte component (sveltejs#5131)
      site: remove an obsolete TODO in blog post (sveltejs#5135)
      Increase timeout for unit build
      Increase timeout for unit tests
      -> v3.24.0
      spread condition for input element (sveltejs#5004)
      update changelog
      fix(5018): compare wholeText instead of data (sveltejs#5028)
      html anchor in head (sveltejs#5071)
      error on expression scope store (sveltejs#5079)
      update changelog
      preprocess self-closing script and style tags (sveltejs#5082)
      update changelog
      fix: Parameters with default values are optional (sveltejs#5083)
      make builds time out after a reasonable period (sveltejs#5100)
      site: fix blog typo (sveltejs#5090)
      ...
    hontas committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    b1fc702 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. Merge branch 'master' of github.com:hontas/svelte

    * 'master' of github.com:hontas/svelte:
    hontas committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    4730331 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/master'

    * upstream/master:
      add updating guard to binding callback (sveltejs#5126)
      Bump lodash from 4.17.15 to 4.17.19 (sveltejs#5152)
      Bump lodash from 4.17.15 to 4.17.19 in /site (sveltejs#5155)
      Fixes sveltejs#5153 (sveltejs#5154)
    hontas committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    297dfcc View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Merge remote-tracking branch 'upstream/master'

    * upstream/master: (140 commits)
      support $$props and $$restProps for custom elements (sveltejs#5608)
      Bump eslint-config to 5.5.0 (sveltejs#5599)
      update changelog
      add Node and Element as known globals (sveltejs#5601)
      docs: fix a11y warning in media elements example (sveltejs#5606)
      Curly braces linting fixes (sveltejs#5585)
      refactor sourcemap and preprocessor tests (sveltejs#5583)
      -> v3.29.4
      fix code generation error with nullish coalescing operator and logical operators (sveltejs#5564)
      -> v3.29.3
      -> v3.29.2
      -> v3.29.1
      docs: fix a11y warning in media elements tutorial (sveltejs#5523)
      update changelog
      get context at start of {#if} update block instead of at the end (sveltejs#5531)
      update changelog
      only allow passing functions to lifecycle functions (sveltejs#5529)
      update changelog
      fix compiler hanging on <slot slot="..."> (sveltejs#5536)
      Add svelte@next caveat to bug report template (sveltejs#5561)
      ...
    hontas committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    527c14d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Merge branch 'master' of https://github.com/sveltejs/svelte

    * 'master' of https://github.com/sveltejs/svelte: (129 commits)
      -> v3.32.3
      fix remove of lone :host selectors (sveltejs#5984)
      -> v3.32.2
      update changelog
      fix extra invalidation with component prop binding to object property (sveltejs#5890)
      update css-tree@^1.1.2 (sveltejs#5958)
      fix :host and :global css scoping (sveltejs#5957)
      Tutorial : a better explanation of component events (sveltejs#4639)
      "What's new in Svelte" February newsletter (sveltejs#5925)
      Change color on 404 page (sveltejs#5932)
      -> v3.32.1
      warn module variables are nonreactive and make them truly nonreactive (sveltejs#5847)
      update changelog
      fix: "foreign" namespace elements should still allow binding 'this' (sveltejs#5942)
      inline `prop_values` in `init` helper (sveltejs#5909)
      update changelog
      don't create class update functions when dependencies aren't reactive (sveltejs#5926)
      fix extraneous store subscription in SSR (sveltejs#5929)
      make `SvelteComponentDev` typings more forgiving (sveltejs#5937)
      make animation/transition params optional (sveltejs#5936)
      ...
    hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    421f2cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e78f39 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18334b4 View commit details
    Browse the repository at this point in the history
  4. only call onDestroy callbacks

    hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    a493b57 View commit details
    Browse the repository at this point in the history
  5. lifecycle hooks and custom elements

    - Call onMount in connectedCallback for customElements
    - register onMount return values as on_disconnect-callbacks for customElements
    - run on_disconnect callbacks in disconnectedCallback
    Pontus Lundin authored and hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7d9636f View commit details
    Browse the repository at this point in the history
  6. simplify logic, trigger tests

    Pontus Lundin authored and hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    95ad63f View commit details
    Browse the repository at this point in the history
  7. fix whitespace, trigger tests

    Pontus Lundin authored and hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    90f5c0a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    628f80e View commit details
    Browse the repository at this point in the history
  9. simplify isCustomElement check

    hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    971ca91 View commit details
    Browse the repository at this point in the history
  10. remove whitespace

    hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    9cc7dd2 View commit details
    Browse the repository at this point in the history
  11. simpler isCustomElement & skip extra function call

    - pass options.customElement down to mount_component
    - remove expensive isCustomElement check
    - only call add_render_callback if not customElement
    hontas committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    1451a88 View commit details
    Browse the repository at this point in the history