Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use dataset with svg elements #995

Merged
merged 34 commits into from
Dec 10, 2017
Merged

don't use dataset with svg elements #995

merged 34 commits into from
Dec 10, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #982

@codecov-io
Copy link

codecov-io commented Dec 10, 2017

Codecov Report

Merging #995 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #995   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         115      115           
  Lines        4271     4271           
  Branches     1359     1359           
=======================================
  Hits         3929     3929           
  Misses        148      148           
  Partials      194      194
Impacted Files Coverage Δ
src/generators/nodes/Attribute.ts 85.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8eaa7e...c4056ab. Read the comment docs.

@Rich-Harris Rich-Harris merged commit c799230 into master Dec 10, 2017
@Rich-Harris Rich-Harris deleted the gh-982 branch December 10, 2017 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG data attributes cause error in Edge
2 participants