Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use dataset with svg elements #995

Merged
merged 34 commits into from
Dec 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2e56d10
start moving logic into Node and its subclasses
Rich-Harris Dec 6, 2017
4b31992
remove unused code
Rich-Harris Dec 6, 2017
39f1af2
start implementing build() methods
Rich-Harris Dec 7, 2017
8e9e323
start moving build logic into individual nodes
Rich-Harris Dec 9, 2017
c6d49b7
move some code around
Rich-Harris Dec 9, 2017
daaad80
remove some unused code
Rich-Harris Dec 9, 2017
e8e05e7
move Slot logic
Rich-Harris Dec 9, 2017
425d019
move attribute logic
Rich-Harris Dec 9, 2017
8072f6a
move binding logic
Rich-Harris Dec 9, 2017
596c432
move shared MustacheTag/RawMustacheTag logic
Rich-Harris Dec 9, 2017
56f34c7
remove elementStack
Rich-Harris Dec 9, 2017
fd24a5c
remove componentStack
Rich-Harris Dec 9, 2017
0cf9259
remove inEachBlock
Rich-Harris Dec 9, 2017
67aca17
Merge branch 'master' into gh-979
Rich-Harris Dec 9, 2017
f4888dd
fix a few typescript issues
Rich-Harris Dec 9, 2017
7f77a10
remove confusing state object from init
Rich-Harris Dec 9, 2017
f6ac3a4
remove some unused stuff
Rich-Harris Dec 9, 2017
e30dc8e
put namespace on Element nodes
Rich-Harris Dec 9, 2017
8eacc25
tidy up
Rich-Harris Dec 9, 2017
48ed685
more tidying up
Rich-Harris Dec 9, 2017
05d63e6
simplify
Rich-Harris Dec 9, 2017
16bac3b
more simplification
Rich-Harris Dec 9, 2017
433623c
rename some stuff to be clearer
Rich-Harris Dec 9, 2017
afa996c
remove unused imports
Rich-Harris Dec 9, 2017
e9dc123
DRY out
Rich-Harris Dec 9, 2017
ea418cd
more tidying up
Rich-Harris Dec 9, 2017
3fa83e3
rename _block to block
Rich-Harris Dec 9, 2017
9b2a7e1
remove preprocess from ssr renderer
Rich-Harris Dec 9, 2017
e974fdc
more tidying up
Rich-Harris Dec 9, 2017
a72a6ca
small tweak, possibly ahead of a much larger one
Rich-Harris Dec 9, 2017
f7d4994
tidy up
Rich-Harris Dec 9, 2017
cf94217
remove unused code
Rich-Harris Dec 10, 2017
7534372
dont use dataset with svg elements - fixes #982
Rich-Harris Dec 10, 2017
c4056ab
merge master -> gh-982
Rich-Harris Dec 10, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/generators/nodes/Attribute.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default class Attribute {

const isLegacyInputType = this.generator.legacy && name === 'type' && this.parent.name === 'input';

const isDataSet = /^data-/.test(name) && !this.generator.legacy;
const isDataSet = /^data-/.test(name) && !this.generator.legacy && !node.namespace;
const camelCaseName = isDataSet ? name.replace('data-', '').replace(/(-\w)/g, function (m) {
return m[1].toUpperCase();
}) : name;
Expand Down
242 changes: 242 additions & 0 deletions test/js/samples/dont-use-dataset-in-svg/expected-bundle.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,242 @@
function noop() {}

function assign(target) {
var k,
source,
i = 1,
len = arguments.length;
for (; i < len; i++) {
source = arguments[i];
for (k in source) target[k] = source[k];
}

return target;
}

function appendNode(node, target) {
target.appendChild(node);
}

function insertNode(node, target, anchor) {
target.insertBefore(node, anchor);
}

function detachNode(node) {
node.parentNode.removeChild(node);
}

function createSvgElement(name) {
return document.createElementNS('http://www.w3.org/2000/svg', name);
}

function setAttribute(node, attribute, value) {
node.setAttribute(attribute, value);
}

function blankObject() {
return Object.create(null);
}

function destroy(detach) {
this.destroy = noop;
this.fire('destroy');
this.set = this.get = noop;

if (detach !== false) this._fragment.u();
this._fragment.d();
this._fragment = this._state = null;
}

function differs(a, b) {
return a !== b || ((a && typeof a === 'object') || typeof a === 'function');
}

function dispatchObservers(component, group, changed, newState, oldState) {
for (var key in group) {
if (!changed[key]) continue;

var newValue = newState[key];
var oldValue = oldState[key];

var callbacks = group[key];
if (!callbacks) continue;

for (var i = 0; i < callbacks.length; i += 1) {
var callback = callbacks[i];
if (callback.__calling) continue;

callback.__calling = true;
callback.call(component, newValue, oldValue);
callback.__calling = false;
}
}
}

function fire(eventName, data) {
var handlers =
eventName in this._handlers && this._handlers[eventName].slice();
if (!handlers) return;

for (var i = 0; i < handlers.length; i += 1) {
handlers[i].call(this, data);
}
}

function get(key) {
return key ? this._state[key] : this._state;
}

function init(component, options) {
component._observers = { pre: blankObject(), post: blankObject() };
component._handlers = blankObject();
component._root = options._root || component;
component._bind = options._bind;

component.options = options;
component.store = component._root.options.store;
}

function observe(key, callback, options) {
var group = options && options.defer
? this._observers.post
: this._observers.pre;

(group[key] || (group[key] = [])).push(callback);

if (!options || options.init !== false) {
callback.__calling = true;
callback.call(this, this._state[key]);
callback.__calling = false;
}

return {
cancel: function() {
var index = group[key].indexOf(callback);
if (~index) group[key].splice(index, 1);
}
};
}

function on(eventName, handler) {
if (eventName === 'teardown') return this.on('destroy', handler);

var handlers = this._handlers[eventName] || (this._handlers[eventName] = []);
handlers.push(handler);

return {
cancel: function() {
var index = handlers.indexOf(handler);
if (~index) handlers.splice(index, 1);
}
};
}

function set(newState) {
this._set(assign({}, newState));
if (this._root._lock) return;
this._root._lock = true;
callAll(this._root._beforecreate);
callAll(this._root._oncreate);
callAll(this._root._aftercreate);
this._root._lock = false;
}

function _set(newState) {
var oldState = this._state,
changed = {},
dirty = false;

for (var key in newState) {
if (differs(newState[key], oldState[key])) changed[key] = dirty = true;
}
if (!dirty) return;

this._state = assign({}, oldState, newState);
this._recompute(changed, this._state);
if (this._bind) this._bind(changed, this._state);

if (this._fragment) {
dispatchObservers(this, this._observers.pre, changed, this._state, oldState);
this._fragment.p(changed, this._state);
dispatchObservers(this, this._observers.post, changed, this._state, oldState);
}
}

function callAll(fns) {
while (fns && fns.length) fns.pop()();
}

function _mount(target, anchor) {
this._fragment.m(target, anchor);
}

function _unmount() {
this._fragment.u();
}

var proto = {
destroy: destroy,
get: get,
fire: fire,
observe: observe,
on: on,
set: set,
teardown: destroy,
_recompute: noop,
_set: _set,
_mount: _mount,
_unmount: _unmount
};

/* generated by Svelte vX.Y.Z */
function create_main_fragment(state, component) {
var svg, g, g_1;

return {
c: function create() {
svg = createSvgElement("svg");
g = createSvgElement("g");
g_1 = createSvgElement("g");
this.h();
},

h: function hydrate() {
setAttribute(g, "data-foo", "bar");
setAttribute(g_1, "data-foo", state.bar);
},

m: function mount(target, anchor) {
insertNode(svg, target, anchor);
appendNode(g, svg);
appendNode(g_1, svg);
},

p: function update(changed, state) {
if (changed.bar) {
setAttribute(g_1, "data-foo", state.bar);
}
},

u: function unmount() {
detachNode(svg);
},

d: noop
};
}

function SvelteComponent(options) {
init(this, options);
this._state = assign({}, options.data);

this._fragment = create_main_fragment(this._state, this);

if (options.target) {
this._fragment.c();
this._fragment.m(options.target, options.anchor || null);
}
}

assign(SvelteComponent.prototype, proto);

export default SvelteComponent;
53 changes: 53 additions & 0 deletions test/js/samples/dont-use-dataset-in-svg/expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/* generated by Svelte vX.Y.Z */
import { appendNode, assign, createSvgElement, detachNode, init, insertNode, noop, proto, setAttribute } from "svelte/shared.js";

function create_main_fragment(state, component) {
var svg, g, g_1;

return {
c: function create() {
svg = createSvgElement("svg");
g = createSvgElement("g");
g_1 = createSvgElement("g");
this.h();
},

h: function hydrate() {
setAttribute(g, "data-foo", "bar");
setAttribute(g_1, "data-foo", state.bar);
},

m: function mount(target, anchor) {
insertNode(svg, target, anchor);
appendNode(g, svg);
appendNode(g_1, svg);
},

p: function update(changed, state) {
if (changed.bar) {
setAttribute(g_1, "data-foo", state.bar);
}
},

u: function unmount() {
detachNode(svg);
},

d: noop
};
}

function SvelteComponent(options) {
init(this, options);
this._state = assign({}, options.data);

this._fragment = create_main_fragment(this._state, this);

if (options.target) {
this._fragment.c();
this._fragment.m(options.target, options.anchor || null);
}
}

assign(SvelteComponent.prototype, proto);
export default SvelteComponent;
4 changes: 4 additions & 0 deletions test/js/samples/dont-use-dataset-in-svg/input.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<svg>
<g data-foo='bar'/>
<g data-foo='{{bar}}'/>
</svg>