-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added gulp build to README #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. Sadly, I think these changes aren't needed. Would you please explain your motivation for editing these ? Have you tried to run the project ?
``` | ||
npm install | ||
``` | ||
into the terminal to install the dependencies. To start the webserver, type | ||
To build the webserver, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not build the webserver but the website.
``` | ||
gulp | ||
gulp build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build command is not needed. Calling only gulp
will build the assets and serve it through a webserver. Calling gulp build
will only build the assets, it does a production build.
Also, I did some enhancements to this doc in #76 . Feel free to check and comment . |
@aslafy-z Thanks for the review! I guess the Docker is not yet merged on the repo hence I didn't see it. |
Is it regarding a new swag proposal or something else? Something else.
Fill the corresponding section below:
(New Swag Proposal)
Q. Have you received swag from this?
Q. How long did it take?
Q. Does it ship worldwide?
(Something else)
Please describe your changes here:
Adds gulp build to README #117