Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gulp build to README #118

Closed
wants to merge 1 commit into from

Conversation

RajatArora08
Copy link
Contributor

  • I've checked that this isn't a duplicate pull request.

Is it regarding a new swag proposal or something else? Something else.
Fill the corresponding section below:

(New Swag Proposal)

  • Company:
  • Reference URL:

Q. Have you received swag from this?
Q. How long did it take?
Q. Does it ship worldwide?

(Something else)
Please describe your changes here:
Adds gulp build to README #117

Copy link
Collaborator

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Sadly, I think these changes aren't needed. Would you please explain your motivation for editing these ? Have you tried to run the project ?

```
npm install
```
into the terminal to install the dependencies. To start the webserver, type
To build the webserver, type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not build the webserver but the website.

```
gulp
gulp build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build command is not needed. Calling only gulp will build the assets and serve it through a webserver. Calling gulp build will only build the assets, it does a production build.

@aslafy-z
Copy link
Collaborator

Also, I did some enhancements to this doc in #76 . Feel free to check and comment .

@RajatArora08
Copy link
Contributor Author

RajatArora08 commented Oct 12, 2018

@aslafy-z Thanks for the review! I guess the Docker is not yet merged on the repo hence I didn't see it.
Regarding this issue, I did a clean install of the repo, but gulp fails with the issue Error: File not found with singular glob: ~/swag-for-dev/site/dist . After your comment, I digged down into the issue and I believe the issue is because gulp default task runs in parallel and the webserver starts before the files are built into the dist directory. I created another PR (#121) for the fix that worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants