feat: add dockerfile 🐳

[aslafy-z]

Add a Dockerfile in order to ease website development with fixed dependencies and tooling.

Two variants:

• devswag:dev: development image, does not contain any code but all the tooling to work with it
• devswag: production image, uses nginx to serve the built artifacts

More infos: https://github.com/aslafy-z/swag-for-dev/blob/add-dockerfile/CONTRIBUTING.md#lets-start-hacking

I just pushed the two variants to my docker-hub if anyone wants to try them without downloading the code (can't use dev images as it needs to be plugged to the code using volumes): https://hub.docker.com/r/zadki3l/devswag/tags/

TODO

• You tell me

[darshkpatel]

Use ADD / VOLUME to get the website files from the folder into the container, also add a CMD line to start the container easily.

[aslafy-z]

No worries I'm working on it

[darshkpatel]

Cool ! , I'd also suggest to have a dev command with nodemom so people can use the docker container while developing too.

[darshkpatel]

LGTM, merge if the image builds.

[aslafy-z]

Notice I had to put the Dockerfile at the root of the repo, making it able to grab data.json for production release. As this project looks more and more like a piece of software than a list, we could maybe move all the content from site/ folder back to the root.

[darshkpatel]

@aslafy-z +1 on that

[plibither8]

@aslafy-z I think it's best if we create a new issue regarding moving all content from site/ to the root folder (as a suggestion). I'm in support of this, since the main content is the site now.

[aslafy-z]

Do you guys feel good if the dev image does not include any other files that package.json and package-lock.jon and requires a volume to work? Not the production one for sure.

[aslafy-z]

Would be great to merge this before fixing #98, I did some changes in the doc that would conflict with doc changes for #98.

[plibither8]

Noted!

[aslafy-z]

I just rebased all the commits. It needs a review, especially on the doc side as I'm still learning english 😉.

@swapagarwal I'd be happy to add a step in the CI that builds the image, do you mind giving me (or the collaborator team, would love to be part of it though) some access to it? Thank you

[aslafy-z]

I still need to delete site/dist/.gitkeep file from releases, so we need to merge #93 before this one.

[aslafy-z]

I added a nginx.conf file configured the same as netlify.toml, it only misses SSL. Not sure if it has to stay here or maybe to a contrib directory. WDYT?

[aslafy-z]

@darshkpatel Could you please redo your review ?

[swapagarwal]

@aslafy-z I missed your comment somehow. 😇
Added you as a collaborator. Welcome to the team! 🎉
Let me know which CI you need access to?

@vikaspotluri123 You have helped a lot in shaping the website. Sent you an invite too! 😉

[vikaspotluri123]

@aslafy-z You mixed port 8000 with port 8080, you need to normalize across the file. I was going to suggest changes, but there are lots of occurrances.

[aslafy-z]

@vikaspotluri123 I thought I changed it everywhere. Done now.

If you have permissions issues, try to drop the -u $(id -u):$(id -g).

[vikaspotluri123]

If you have permissions issues, try to drop the -u $(id -u):$(id -g).

I'm going to trust you on this. Docker on Windows makes mapping volumes to an existing file very difficult, and my linux vm is on a mechanical drive.

[aslafy-z]

I think I found it! dist folder has to exist
see https://stackoverflow.com/questions/44574078/mount-non-existing-host-directory-into-non-root-container

I was able to reproduce using https://labs.play-with-docker.com/

# Change user to non-root

adduser -D devswag
chmod o+rw /var/run/docker.sock # ugly
su - devswag

# That has to be another copy/paste

git clone https://github.com/aslafy-z/swag-for-dev -b add-dockerfile
cd swag-for-dev/
docker build -t devswag:dev --target base .
mkdir dist # CREATE DIST FOLDER
docker run -it --rm \
  -v $(pwd)/data.json:/devswag/data.json \
  -v $(pwd)/src:/devswag/src \
  -v $(pwd)/gulpfile.js:/devswag/gulpfile.js \
  -v $(pwd)/get-data.js:/devswag/get-data.js \
  -v $(pwd)/dist:/devswag/dist \
  -u $(id -u):$(id -g) \
  -p 8080:8080 -p 35729:35729 devswag:dev

[swapagarwal]

I pulled the latest commit and docker run... serves the website at http://127.0.0.1:8080/ correctly (without running mkdir dist).