feat(es/ast): Support abstract auto-accessors (#8736)

**Description:** Supports abstract auto-accessors: https://github.com/microsoft/TypeScript/blob/3e91592b06096e1cfdc6eb05a95838831e547e22/tests/baselines/reference/autoAccessorAllowedModifiers.js#L9 **BREAKING CHANGE:** Adds a new is_abstract property
swc-project · Apr 24, 2024 · 1155ac7 · 1155ac7
1 parent d925f8a
commit 1155ac7
Show file tree

Hide file tree

Showing 37 changed files with 263 additions and 71 deletions.
diff --git a/crates/swc_ecma_ast/src/class.rs b/crates/swc_ecma_ast/src/class.rs
@@ -332,6 +332,9 @@ pub struct AutoAccessor {
     #[cfg_attr(feature = "serde-impl", serde(default))]
     pub accessibility: Option<Accessibility>,
 
+    #[cfg_attr(feature = "serde-impl", serde(default))]
+    pub is_abstract: bool,
+
     #[cfg_attr(feature = "serde-impl", serde(default))]
     pub is_override: bool,
 
@@ -349,6 +352,7 @@ impl Take for AutoAccessor {
             is_static: false,
             decorators: Take::dummy(),
             accessibility: None,
+            is_abstract: false,
             is_override: false,
             definite: false,
         }

diff --git a/crates/swc_ecma_codegen/src/lib.rs b/crates/swc_ecma_codegen/src/lib.rs
@@ -1384,6 +1384,11 @@ where
             space!();
         }
 
+        if n.is_abstract {
+            keyword!("abstract");
+            space!();
+        }
+
         if n.is_override {
             keyword!("override");
             space!();

diff --git a/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/input.js b/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/input.js
@@ -15,5 +15,6 @@ class MyClass extends Base {
     public prop13: string;
     private static prop14: string;
     protected override accessor prop15 = 5;
+    abstract accessor abstractAccessor: string;
     [value]?: string[];
 }
diff --git a/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/output.js b/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/output.js
@@ -15,5 +15,6 @@ class MyClass extends Base {
     public prop13: string;
     private static prop14: string;
     protected override accessor prop15 = 5;
+    abstract accessor abstractAccessor: string;
     [value]?: string[];
 }
diff --git a/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/output.min.js b/crates/swc_ecma_codegen/tests/fixture/typescript/class_prop/output.min.js
diff --git a/crates/swc_ecma_parser/src/parser/class_and_fn.rs b/crates/swc_ecma_parser/src/parser/class_and_fn.rs
@@ -1094,6 +1094,7 @@ impl<I: Tokens> Parser<I> {
                     is_static,
                     decorators,
                     accessibility,
+                    is_abstract,
                     is_override,
                     definite,
                 }));

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor1.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor1.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -98,6 +99,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -139,6 +141,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -173,6 +176,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor10.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor10.json
@@ -57,6 +57,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -162,6 +163,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -302,6 +304,7 @@
                     "isStatic": false,
                     "decorators": [],
                     "accessibility": null,
+                    "isAbstract": false,
                     "isOverride": false,
                     "definite": false
                   },
@@ -436,6 +439,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -497,6 +501,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor11.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor11.json
@@ -222,6 +222,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor2.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor2.json
@@ -72,6 +72,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -114,6 +115,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -163,6 +165,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -205,6 +208,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor3.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor3.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -98,6 +99,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -139,6 +141,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -173,6 +176,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor4.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor4.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -98,6 +99,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -139,6 +141,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -173,6 +176,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor6.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor6.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor7.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor7.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": true,
           "isOverride": false,
           "definite": false
         }
@@ -125,6 +126,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor8.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor8.json
@@ -64,6 +64,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -105,6 +106,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -173,6 +175,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -214,6 +217,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -310,6 +314,7 @@
                 "isStatic": false,
                 "decorators": [],
                 "accessibility": null,
+                "isAbstract": false,
                 "isOverride": false,
                 "definite": false
               },
@@ -351,6 +356,7 @@
                 "isStatic": true,
                 "decorators": [],
                 "accessibility": null,
+                "isAbstract": false,
                 "isOverride": false,
                 "definite": false
               }

diff --git a/crates/swc_ecma_parser/tests/tsc/autoAccessor9.json b/crates/swc_ecma_parser/tests/tsc/autoAccessor9.json
@@ -57,6 +57,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -156,6 +157,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -299,6 +301,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -551,6 +554,7 @@
           "isStatic": false,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },
@@ -650,6 +654,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         }
@@ -749,6 +754,7 @@
           "isStatic": true,
           "decorators": [],
           "accessibility": null,
+          "isAbstract": false,
           "isOverride": false,
           "definite": false
         },