feat(es/minifier): Support format.inline_script
#8252
Merged
+151
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
requested changes
Nov 9, 2023
kdy1
changed the title
inline_scriptformat.inline_script
bvanjoi
force-pushed
the
partial-7602
branch
from
2942278 to
ef6c1e2
Compare
kdy1
reviewed
Nov 13, 2023
crates/swc_ecma_codegen/src/lib.rs
Outdated
| @@ -75,6 +75,52 @@ where | |||
| pub wr: W, | |||
| } | |||
|
|
|||
| fn replace_close_inline_script(raw: &str) -> String { | |||
There was a problem hiding this comment.
This is still unconditional. Can we check for the existence of the pattern and return Cow::Borrowed(raw) if it's not found?
bvanjoi
force-pushed
the
partial-7602
branch
from
ef6c1e2 to
76af2f8
Compare
kdy1
reviewed
Nov 13, 2023
bvanjoi
force-pushed
the
partial-7602
branch
from
76af2f8 to
821aeeb
Compare
kdy1
reviewed
Nov 13, 2023
kdy1
approved these changes
Nov 14, 2023
swc-bot
reviewed
Nov 14, 2023
|
Why doesn't |
|
It works. The red line is about typescript typings |
|
It really doesn't work. The left side is the input, the right side is the output. Code is not formatted successfully. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as a partial solution for issue #7602, should we proceed, the implementation of ends_with will be needed.