Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/minifier): Improve format.inline_script #8292

Merged
merged 2 commits into from
Nov 15, 2023
Merged

perf(es/minifier): Improve format.inline_script #8292

merged 2 commits into from
Nov 15, 2023

Conversation

ZakisM
Copy link
Contributor

@ZakisM ZakisM commented Nov 15, 2023

Improves on #8252 fn replace_close_inline_script by removing unsafe and improving performance by ~35%

@ZakisM ZakisM requested a review from a team as a code owner November 15, 2023 20:51
@CLAassistant
Copy link

CLAassistant commented Nov 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kdy1
kdy1 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) November 15, 2023 22:02
@kdy1
Copy link
Member

kdy1 commented Nov 15, 2023

Thank you!

@kdy1 kdy1 added this to the Planned milestone Nov 15, 2023
@kdy1 kdy1 merged commit 7d1836d into swc-project:main Nov 15, 2023
141 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.
3 participants
@ZakisM @CLAassistant @kdy1