20210909 styles upgrade #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
display it only if both `page.title` and `site.title` are defined.
Pull Request: carpentries/styles#406 * change all-in-one file to have the same 'depth' as episode files * move the core script of aio.md into _includes/aio-script.md * include comment to inform maintainers to not edit the file * move aio.md to the root of styles repository
See https://jekyllrb.com/news/2019/08/20/jekyll-4-0-0-released/#cache-all-the-things- & https://github.com/jekyll/jekyll/releases/tag/v4.0.0 It appears during `make site` & `make serve`.
Co-authored-by: stamper <tbyhdgs@gmail.com>
HTML comments end up in the generated HTML pages: they're not displayed by the browsers but they're still present there. Liquid comments do not end up in the generated HTML pages
lesson.scss: define 'inline' class for images
Automatically add deep anchor links using AnchorJS
Fix broken "How to contribute" link
Also, make 'require()' function not fail by default. The only case where we really need to fail is when 'kramdown' parser is not specified. This is a highly unlikely scenario, tbh (because arguments to `lesson_check.py` are set in the Makefile), but we can think about reworking/optimizing this part later.
lesson_check.py: report check status at the end
util.py: load_yaml: Don't fail when it's not necessary
lesson_check.py: fix error message for the 'defaults' check
lesson_check.py: use proper regex for matching episode files
1. Read `config.yml` file only once and store the contents in a global variable `CONFIG`. We're currently reading this file twice. 2. Detect lesson life cycle in `main` instead of making `check_config` return it. 3. Replace `using_remote_theme` function with a single test that checks that `remote_theme` keyword is present in `_config.yml` 4. CheckEpisode class: `check` method: move "remote theme test" inside the `check_reference_inclusion`. 5. main: mvoe "remote theme test" inside the `read_references`
lesson-check.py: read `config.yml` only once
Port of carpentries/instructor-training@f488d24 Co-authored-by: François Michonneau <francois.michonneau@gmail.com> Co-authored-by: François Michonneau <francois.michonneau@gmail.com>
Port of carpentries/instructor-training@dc1b52a Co-authored-by: maneesha sane <maneeshasane@gmail.com> Co-authored-by: maneesha sane <maneeshasane@gmail.com>
Co-authored-by: Toby Hodges <tbyhdgs@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like the template for this lesson hasn't been updated in a while and it contains an older version of jQuery that is known to have some security vulnerabilities. This PR brings the latest version of the lesson template.