Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.md: link to Git Bash #475

Closed
wants to merge 5 commits into from
Closed

setup.md: link to Git Bash #475

wants to merge 5 commits into from

Conversation

cleary3
Copy link
Contributor

@cleary3 cleary3 commented Feb 21, 2018

Add a link for 'git bash.' Up to this point, 'git bash' has not been mentioned in the Programming with Python lesson material. Without the link, it's unclear whether 'git bash' is a product or a typo.

Add a link for 'git bash.' Up to this point, 'git bash' has not been mentioned in the Programming with Python lesson material. Without the link, it's unclear whether 'git bash' is a product or a typo.
@rgaiacs
Copy link
Contributor

rgaiacs commented Feb 22, 2018

Not that type python in Git Bash will probably return

command not found: python

You probably want to point Windows users to the Anaconda prompt.

Also, improve language in setup.md

Closes #457

Signed-off-by: Maxim Belkin <maxim.belkin@gmail.com>
@maxim-belkin
Copy link
Contributor

@cleary3 could you please rebase this PR and change git bash to Git Bash?

gcapes and others added 3 commits April 3, 2018 17:00
Exercise: 'Check Your Understanding'

Closes #454

Closes #455

Signed-off-by: Maxim Belkin <maxim.belkin@gmail.com>
Add a link for 'git bash.' Up to this point, 'git bash' has not been mentioned in the Programming with Python lesson material. Without the link, it's unclear whether 'git bash' is a product or a typo.
@cleary3
Copy link
Contributor Author

cleary3 commented Apr 4, 2018

My git novice threads are showing through. I believed I've rebased my pull request and update it, as requested.

@maxim-belkin
Copy link
Contributor

not a problem. give me a few minutes - I'll either clean this up myself or post instructions how to fix things

@maxim-belkin
Copy link
Contributor

So, Git Bash is first mentioned a few lines above (line 28) so we actually have to add the link there.
Let's fix it the hard way:

$ git checkout patch-1
$ git reset --hard origin/gh-pages
### edit setup.md to add the link here ###
$ git add -u 
$ git commit ...

@maxim-belkin maxim-belkin changed the title Update setup.md – add 'git bash' link setup.md: link to Git Bash Apr 8, 2018
@@ -25,7 +25,7 @@ you should have already
[installed Anaconda](http://swcarpentry.github.io/workshop-template/#python)
which includes the notebook.

To start the notebook server, open a terminal or git bash and type the command:
To start the notebook server, open a terminal or git bash and execute the command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to Git Bash here

@maxim-belkin
Copy link
Contributor

I've updated setup.md and I believe this issue is now resolved.
Thank you for your contribution anyway, @cleary3!

fmichonneau pushed a commit to fmichonneau/python-novice-inflammation that referenced this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants