Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a radial expansion to the BBH ID pipeline #5691

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jan 4, 2024

Proposed changes

Upgrade instructions

For the spectre bbh generate-id command, you must now also specify the radial expansion velocity with --radial-expansion-velocity/-a.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Jan 4, 2024
@knelli2 knelli2 requested a review from nilsvu January 4, 2024 03:49
@nilsvu nilsvu merged commit 1aee387 into sxs-collaboration:develop Jan 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants