Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a radial expansion to the BBH ID pipeline #5691

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions support/Pipelines/Bbh/InitialData.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def id_parameters(
mass_ratio: float,
separation: float,
orbital_angular_velocity: float,
radial_expansion_velocity: float,
refinement_level: int,
polynomial_order: int,
):
Expand All @@ -30,6 +31,7 @@ def id_parameters(
mass_ratio: Defined as q = M_A / M_B >= 1.
separation: Coordinate separation D of the black holes.
orbital_angular_velocity: Omega_0.
radial_expansion_velocity: adot_0.
refinement_level: h-refinement level.
polynomial_order: p-refinement level.
"""
Expand All @@ -50,6 +52,7 @@ def id_parameters(
"ExcisionRadiusRight": 0.89 * 2.0 * M_A,
"ExcisionRadiusLeft": 0.89 * 2.0 * M_B,
"OrbitalAngularVelocity": orbital_angular_velocity,
"RadialExpansionVelocity": radial_expansion_velocity,
# Resolution
"L": refinement_level,
"P": polynomial_order,
Expand All @@ -60,6 +63,7 @@ def generate_id(
mass_ratio: float,
separation: float,
orbital_angular_velocity: float,
radial_expansion_velocity: float,
refinement_level: int,
polynomial_order: int,
id_input_file_template: Union[str, Path] = ID_INPUT_FILE_TEMPLATE,
Expand All @@ -81,6 +85,7 @@ def generate_id(
mass_ratio=mass_ratio,
separation=separation,
orbital_angular_velocity=orbital_angular_velocity,
radial_expansion_velocity=radial_expansion_velocity,
refinement_level=refinement_level,
polynomial_order=polynomial_order,
)
Expand Down Expand Up @@ -112,6 +117,15 @@ def generate_id(
help="Orbital angular velocity Omega_0.",
required=True,
)
@click.option(
"--radial-expansion-velocity",
"-a",
type=float,
help=(
"Radial expansion velocity adot0 which is radial velocity over radius."
),
required=True,
)
@click.option(
"--refinement-level",
"-L",
Expand Down
2 changes: 1 addition & 1 deletion support/Pipelines/Bbh/InitialData.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Background: &background
Spin: [0., 0., 0.]
Center: [0., 0., 0.]
AngularVelocity: {{ OrbitalAngularVelocity }}
Expansion: 0.
Expansion: {{ RadialExpansionVelocity }}
LinearVelocity: [0., 0., 0.]
FalloffWidths: [4.8, 4.8]

Expand Down
1 change: 1 addition & 0 deletions support/Pipelines/Bbh/Inspiral.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def inspiral_parameters(
"XCoordB": id_domain_creator["ObjectB"]["XCoord"],
# Initial functions of time
"InitialAngularVelocity": id_binary["AngularVelocity"],
"RadialExpansionVelocity": float(id_binary["Expansion"]),
# Resolution
"L": refinement_level,
"P": polynomial_order,
Expand Down
2 changes: 1 addition & 1 deletion support/Pipelines/Bbh/Inspiral.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ DomainCreator:
TimeDependentMaps:
InitialTime: 0.0
ExpansionMap:
InitialValues: [1.0, 0.0]
InitialValues: [1.0, {{ RadialExpansionVelocity }}]
AsymptoticVelocityOuterBoundary: -1.0e-6
DecayTimescaleOuterBoundaryVelocity: 50.0
RotationMap:
Expand Down
4 changes: 4 additions & 0 deletions tests/support/Pipelines/Bbh/Test_InitialData.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def test_generate_id(self):
mass_ratio=1.5,
separation=20.0,
orbital_angular_velocity=0.01,
radial_expansion_velocity=-1.0e-5,
refinement_level=1,
polynomial_order=5,
)
Expand All @@ -39,6 +40,7 @@ def test_generate_id(self):
self.assertAlmostEqual(params["ExcisionRadiusRight"], 1.068)
self.assertAlmostEqual(params["ExcisionRadiusLeft"], 0.712)
self.assertEqual(params["OrbitalAngularVelocity"], 0.01)
self.assertEqual(params["RadialExpansionVelocity"], -1.0e-5)
self.assertEqual(params["L"], 1)
self.assertEqual(params["P"], 5)
# COM is zero
Expand All @@ -60,6 +62,8 @@ def test_cli(self):
"20",
"--orbital-angular-velocity",
"0.01",
"--radial-expansion-velocity",
"-1.0e-5",
"--refinement-level",
"1",
"--polynomial-order",
Expand Down
2 changes: 2 additions & 0 deletions tests/support/Pipelines/Bbh/Test_Inspiral.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def setUp(self):
mass_ratio=1.5,
separation=20.0,
orbital_angular_velocity=0.01,
radial_expansion_velocity=-1.0e-5,
refinement_level=1,
polynomial_order=5,
run_dir=self.test_dir / "ID",
Expand Down Expand Up @@ -59,6 +60,7 @@ def test_inspiral_parameters(self):
self.assertEqual(params["XCoordA"], 8.0)
self.assertEqual(params["XCoordB"], -12.0)
self.assertEqual(params["InitialAngularVelocity"], 0.01)
self.assertEqual(params["RadialExpansionVelocity"], -1.0e-5)
self.assertEqual(params["L"], 1)
self.assertEqual(params["P"], 5)

Expand Down
1 change: 1 addition & 0 deletions tests/support/Pipelines/Bbh/Test_Ringdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def setUp(self):
mass_ratio=1.5,
separation=20.0,
orbital_angular_velocity=0.01,
radial_expansion_velocity=-1.0e-5,
refinement_level=1,
polynomial_order=5,
run_dir=self.test_dir / "ID",
Expand Down