Databox runtime retrieval #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Jan 19, 2024
| /// A list of all the mutable tags that have subitems | ||
| using mutable_item_parent_tags = | ||
| tmpl::remove_if<mutable_item_creation_tags, | ||
| tmpl::not_<tmpl::bind<detail::has_subitems, tmpl::_1>>>; |
There was a problem hiding this comment.
[optional] remove_if<..., not_<...>> -> filter<..., ...>. Similar a few times below.
| DataBox<tmpl::list<Tags...>>::reset_compute_item() { | ||
| // reference items do not need to be reset | ||
| SPECTRE_ALWAYS_INLINE bool DataBox<tmpl::list<Tags...>>::reset_compute_item() { | ||
| // reference items do not need to be reset, but it |
| *val = 2.5; | ||
| *str = "My Sample String 2"; | ||
| }, | ||
| make_not_null(&db::as_access(box))); |
There was a problem hiding this comment.
Shouldn't have as_access, if I'm understanding the comment above correctly.
| constexpr bool using_db_access = std::is_same_v<std::decay_t<T>, db::Access>; | ||
| // INFO("test mutate apply"); | ||
| // auto box = db::create< | ||
| // db::AddSimpleTags< |
kidder
reviewed
Jan 22, 2024
nilsdeppe
force-pushed
the
databox_runtime_retrieval
branch
2 times, most recently
from
7d4b056
to
949c549
Compare
|
I rebased and pushed fixups. Thanks for the reviews! |
kidder
reviewed
Feb 8, 2024
| // reference items do not need to be reset, but it still needs to be handled | ||
| // here. Partly just so we get an error if we are calling this function | ||
| // incorrectly and because we need to call this function during resets | ||
| // to get dependency tracking correctly. When compute tags depend on reference |
There was a problem hiding this comment.
...tracking correct when compute tags...
There was a problem hiding this comment.
I squashed this change into the fixup. Waiting for @wthrowe before squashing the fixups in
nilsdeppe
force-pushed
the
databox_runtime_retrieval
branch
from
949c549
to
93f2a23
Compare
nilsdeppe
force-pushed
the
databox_runtime_retrieval
branch
from
93f2a23
to
b4cffe3
Compare
|
Squashed! Thank you again for the reviews! |
kidder
approved these changes
Feb 9, 2024
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds a method of getting a type-erased DataBox. Some retrieval errors become runtime, but this will allow us to move more code into cpp files, which will hopefully decrease compile time.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments