Add regression tests to elliptic input files #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
regression_tests
branch
5 times, most recently
from
c2ef709
to
c439b93
Compare
nilsdeppe
reviewed
Mar 1, 2024
nilsvu
force-pushed
the
regression_tests
branch
2 times, most recently
from
fc60986
to
8f09645
Compare
Allows to list the expected data directly in the input file, rather than requiring that the executable writes the data to the H5 file. This enables stringent regression tests.
|
@nilsdeppe nope this should be good to go. It's a good check that #5789 doesn't mess anything up. |
3 tasks
nilsdeppe
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This reproduces the issue mentioned in #5756: the test added to
BinaryBlackHole.yamlpassed before #5709 and fails now on develop. Note that the test takes too long to run on CI, so CI still passes.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments