Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some elliptic AMR projectors #5721

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Add some elliptic AMR projectors #5721

merged 9 commits into from
Feb 23, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 26, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from kidder January 26, 2024 18:33
@nilsvu nilsvu changed the title Add two elliptic AMR projectors Add some elliptic AMR projectors Jan 26, 2024
@nilsvu nilsvu force-pushed the elliptic_amr branch 10 times, most recently from 1e96fb3 to c1b7f6b Compare February 2, 2024 00:12
@nilsvu
Copy link
Member Author

nilsvu commented Feb 2, 2024

@kidder I made this PR very small now, and will open follow-ups later. Could you review this please?

kidder
kidder requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should test the projectors

.clang-tidy Outdated
@@ -76,6 +76,8 @@ Checks: '*,
-readability-magic-numbers,
# Same as llvm-qualified-auto above.,
-readability-qualified-auto,
# Access specifies can be useful to structure code,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifies -> specifiers

@nilsvu
Copy link
Member Author

nilsvu commented Feb 17, 2024

@kidder Updated and added a test for p-AMR in action. h-AMR isn't supported by the action-testing framework yet as we discussed, so I can enable that once we have added support.

Please ignore the first two commits (cherry-picked from #5163 and #5781).

@nilsvu nilsvu force-pushed the elliptic_amr branch 2 times, most recently from c0c7000 to 3da95bb Compare February 19, 2024 00:35
@nilsvu nilsvu requested a review from kidder February 21, 2024 01:08
@nilsvu nilsvu force-pushed the elliptic_amr branch 2 times, most recently from fc865dc to 6946f5d Compare February 22, 2024 22:39
kidder
kidder previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a rebase

@nilsvu
Copy link
Member Author

nilsvu commented Feb 23, 2024

Rebased. Thanks for reviewing.

@kidder kidder merged commit 7580cf4 into sxs-collaboration:develop Feb 23, 2024
22 checks passed
@nilsvu nilsvu deleted the elliptic_amr branch February 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidder kidder kidder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsvu @kidder