Allow random hp AMR for testing #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
random_amr
branch
2 times, most recently
from
d105fa9
to
3f207ea
Compare
3 tasks
kidder
reviewed
Feb 21, 2024
| static double upper_bound() { return 1.0; } | ||
| "Possible refinement types and their probability, specified as integer " | ||
| "weights. For example, set 'Split: 1' and 'DoNothing: 4' to split each " | ||
| "element with 25% probability. The refinement is evaluated in each " |
There was a problem hiding this comment.
25 -> 20 (total weight is 5) (or change 4 -> 3 for DoNothing)
| * \note This criterion is primarily useful for testing the mechanics of | ||
| * h-refinement | ||
| * You can specify a probability for each possible `amr::Flag`. It is evaluated | ||
| * in each dimension separately. |
There was a problem hiding this comment.
mention here (or the option help) that:
- probability for a flag is its weight over sum of weights
- you do not need to specify flags with weight 0
- if all weights are 0, DoNothing is always chosen
Support triggering any of the AMR flags with a specified probability, rather than only h-refinement. Simplifies the reasoning of the AMR criterion and gives more control over the types of refinement. Still enforces a maximum refinement level, which can be deleted once it's enforced globally with an AMR policy.
|
Done, thanks for reviewing. |
kidder
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support triggering any of the AMR flags with a specified probability, rather than only h-refinement. Simplifies the reasoning of the AMR criterion and gives more control over the types of refinement. Still enforces a maximum refinement level, which can be deleted once it's enforced globally with an AMR policy.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments