Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Auto parsing failure print the Label #5766

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Feb 14, 2024

Example output:

In group SpatialDiscretization:
In group DiscontinuousGalerkin:
While parsing option TciOptions:
While creating a TciOptions:
While parsing option MagneticFieldCutoff:
While creating a Auto:
While creating a variant:
At line 67 column 28:
Failed to convert value to type AutoLabel or double: bla

Possible errors:

While creating a variant:
While creating a AutoLabel:
At line 67 column 28:
Failed to parse as Auto label "DoNotCheckMagneticField"

While creating a variant:
At line 67 column 28:
Failed to convert value to type double: bla
############ ERROR ############

This is not quite the issue from #2654, which is about the displayed name rather than the error message.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe wthrowe force-pushed the auto_error branch 2 times, most recently from dc54cb0 to cb14346 Compare February 14, 2024 21:02
@knelli2
Copy link
Contributor

knelli2 commented Feb 17, 2024

gcc-10 failure dealt with by #5780 .

@knelli2 knelli2 merged commit 0acdb09 into sxs-collaboration:develop Feb 17, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants