Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable paraview rendering tests on CI temporarily #5780

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Feb 16, 2024

Proposed changes

Turns out #5773 didn't actually fix this issue, it just introduced a new one. I figure let's just temporarily disable the tests until we can actually figure things out so we can get CI working again.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added priority critical for progress bugfix ci/cd Continuous integration & deployment labels Feb 16, 2024
@knelli2 knelli2 requested a review from nilsvu February 16, 2024 18:53
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange that the apt-get installation issue didn't appear yesterday when #5773 was merged. Either way, I agree with disabling temporarily.

@nilsvu nilsvu merged commit 2f5a828 into sxs-collaboration:develop Feb 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ci/cd Continuous integration & deployment priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants