Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize LTS communication handling #5864

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Mar 18, 2024

The old version made assumptions based on the Adams-Bashforth method, but that won't be true for other methods.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Not obviously the same for all time steppers, and will not be as
simple as a less-than comparison for AMPC.
Required for std::map<TimeStepId, T> to work with data from neighbors.
It's sorted by TimeStepId, but that may not agree with the order the
messages need to be processed in, depending on the TimeStepper in use.
Comment on lines +75 to +76
/// computational ordering of those states. For others, (e.g.,
/// overlapping steps) it is arbitrary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe say what the arbitrary decision is? Just that for the arbitrary case, we check which step size is smaller?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that simple. That's just the last tie-breaker. The part of the algorithm that does the meaningful ordering also distinguishes some arbitrary cases.

@nilsdeppe nilsdeppe merged commit c7c91c0 into sxs-collaboration:develop Mar 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants